Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13_0_X] Fix typos in jetsAK4 CHS and Puppi tables #42710

Merged
merged 3 commits into from
Sep 5, 2023
Merged

[13_0_X] Fix typos in jetsAK4 CHS and Puppi tables #42710

merged 3 commits into from
Sep 5, 2023

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Sep 4, 2023

PR description:

Backport of #42670

This pull request fixes a few typos in the jetsAK4 CHS and Puppi tables:

(1) Fix to the btagRobustParTAK4CvB definition: the previous definition was using the pfDeepFlavourJetTags instead of pfParticleTransformerAK4JetTagsfor theprobbbandproblepb` scores in the denominator. This affects both the CHS and Puppi AK4 jet tables, and probably(?) affects the official production.

(2) Fix to the nanoAOD_addDeepInfoAK4() fucntion in the jetsAK4_Puppi_cff.py: this should only affects private/custom productions.

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Sep 4, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2023

A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms hqucms mentioned this pull request Sep 4, 2023
Merged
@simonepigazzini
Copy link
Contributor

enable nano

@simonepigazzini
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15a7d6/34595/summary.html
COMMIT: 5c125b7
CMSSW: CMSSW_13_0_X_2023-09-04-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42710/34595/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 240 lines from the logs
  • Reco comparison results: 17 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283193
  • DQMHistoTests: Total failures: 1013
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3282158
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12351
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12327
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.445 2.445 -0.000 ( -0.0% ) 5.45 5.42 +0.4% 2.088 2.087
2500.311 2.552 2.552 0.000 ( +0.0% ) 4.89 4.88 +0.2% 2.519 2.521
2500.312 2.496 2.497 -0.000 ( -0.0% ) 5.08 5.06 +0.3% 2.509 2.510
2500.33 1.240 1.240 0.000 ( +0.0% ) 10.37 10.36 +0.1% 2.207 2.208
2500.331 1.604 1.603 0.000 ( +0.0% ) 5.42 5.46 -0.9% 2.396 2.400
2500.332 1.485 1.485 0.000 ( +0.0% ) 7.85 7.83 +0.3% 2.306 2.309
2500.401 2.158 2.158 0.000 ( +0.0% ) 5.47 5.50 -0.5% 1.948 1.947
2500.501 1.762 1.762 0.000 ( +0.0% ) 9.30 9.34 -0.4% 1.833 1.829
2500.511 1.146 1.146 0.000 ( +0.0% ) 4.57 4.57 +0.1% 2.151 2.152
2500.5111 1.504 1.504 0.000 ( +0.0% ) 4.07 4.05 +0.6% 2.227 2.234
2500.601 2.025 2.025 0.000 ( +0.0% ) 13.30 13.27 +0.2% 1.711 1.710

@simonepigazzini
Copy link
Contributor

+1

same changes observed in DQM to the c vs b node. This is good to go for the NANO (re)production of prompt 2023

@simonepigazzini
Copy link
Contributor

Thanks again @hqucms

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3d05630 into cms-sw:CMSSW_13_0_X Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed orp-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@hqucms @cmsbuild @simonepigazzini @antoniovilela